Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locked time zone for tests #5095

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

raysarebest
Copy link

Phabricator: N/A

Notes

testEditMilestoneHundredOnUserTalkPage() in the default test suite would fail if the test system was set to a time zone far enough east. This is due to the fact that it compares against the string literal "7/16/21", but uses a date formatter that depends on the current system calendar/time zone/etc

This PR addresses this issue by locking the time zone on the test system to America/New_York, thereby eliminating the system time zone as a dependency of the tests

Test Steps

  1. Set the system the tests will be run upon to Europe/Amsterdam (or other Central European time zone)
  2. Run the default Wikipedia test suite
  3. Observe that all the tests (including testEditMilestoneHundredOnUserTalkPage()) pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant