Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes needed to fix local rendering of PCS read more section #5107

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Changes needed to fix local rendering of PCS read more section #5107

merged 3 commits into from
Jan 16, 2025
+3 −3

Conversation

tonisevener
Copy link
Collaborator

@tonisevener tonisevener commented Dec 3, 2024 •
edited
Loading

Phabricator: N/A

Notes

These changes fix a bug where the "Read More" section would not show in article when running against a local PCS service.

Test Steps

Regression

  1. Confirm on main Wikipedia scheme, the bottom "Read More" section still displays as before on articles.

Optional

  1. Clone and run locally our mobileapps service.
  2. Choose the "Local Page Content Service & Announcements" scheme in Xcode, run on simulator.
  3. Confirm the bottom "Read More" section still displays as before on articles.

@tonisevener tonisevener merged commit a60f25e into main Jan 16, 2025
4 checks passed
@tonisevener tonisevener deleted the fix-local-pcs-readmore branch January 16, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-olson1214 l-olson1214 l-olson1214 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonisevener @l-olson1214