Remove custom navigation bar #5121
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ach tab view - also hide tab bar in article view controller on push
- header view still needs work
- plus remove unnecessary .overFullScreen presentation styles - Fixes to Edit Link / Insert Link close button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T363606
Notes
This PR removes the ViewController, NavigationBar, NavigationBarHider, and WMFThemeableNavigationController superclasses and deals with the fallout. There other other smaller cleanup items, but those are the main ones.
I added a WMComponentNavigationController (subclass of UINavigationController) in WMFComponents for us to switch to. All legacy view controllers and newer WMFComponentViewControllers use this for navigating.
I also added a WMFNavigationBarConfiguring and default protocol implementation of
configureNavigationBar(...)that all UIViewControllers can (optionally) call. I also tried to comb through most of the app and use this method in everyviewWillAppear, so that all configuration flows through one method.There are still bugs, code cleanup and design review feedback that I need to do, but I wanted to get this up (at least in draft form) so that we can discuss it and potentially start review.
Test Steps