A/B Test logic for Article Search Bar #5181
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T383829
(Also a little bit of https://phabricator.wikimedia.org/T384952)
Notes
This PR sets up the search experiment for the Article view. It assigns a 50/50 experiment for users in the correct projects upon app launch and sends a related
action:launch action_data:{group assignment}
event to theios_search
schema. It references this value in the existingneedsSearchBar
logic on ArticleViewController. Then for all otherios_search
events, we send theaction_data: {group_assignment}
value.While I was in here I cleaned up a few things:
SearchViewController
source
logic. It was inferred from the navigation stack, which was buggy. Now you must pass it in from the outside.action
,action_data
,source
, etc.Test Steps
action_data
key.a
, you should see magnifying glass button in nav bar. If group assignment in step 4 wasb
, you should see article search bar.ios_search
events in the console. Be suresource
of these events are "article" and thataction_data
group name is still send with each event.ios_search
events in the console. Be suresource
of these events are "top_of_feed" and thataction_data
group name is still send with each event.ios_search
events in the console. Be suresource
of these events are "search_tab" and thataction_data
group name is still send with each event.action_data
group name inios_search
has NOT changed groups.