Npm audit - major update of A LOT of packages (#378)

* Fix style issues in tests * Add stylelint exception for px unit * Update A LOT of dependencies * Replace utils/confirm with hooks/useConfirm to make sure all hooks aare used at the top-level * Go back to [email protected] Co-authored-by: Stephane Bisson <[email protected]>
wikimedia · Sep 27, 2021 · 69209f3 · 69209f3
1 parent 8b5528d
commit 69209f3
Show file tree

Hide file tree

Showing 18 changed files with 15,614 additions and 22,484 deletions.
diff --git a/.stylelintrc.json b/.stylelintrc.json
@@ -4,6 +4,7 @@
     "selector-attribute-quotes": null,
     "no-descending-specificity": null,
     "declaration-no-important": null,
-    "selector-type-no-unknown": null
+    "selector-type-no-unknown": null,
+    "declaration-property-unit-disallowed-list": null
   }
 }
diff --git a/cypress/integration/search-spec.js b/cypress/integration/search-spec.js
@@ -60,7 +60,7 @@ describe('Article search', () => {
     searchPage.search('cat')
     cy.getCenterSoftkeyButton().should('not.have.text')
     searchPage.results().first()
-    cy.wait(500)
+    cy.wait(500) // eslint-disable-line cypress/no-unnecessary-waiting
     cy.downArrow()
     cy.getCenterSoftkeyButton().should('have.text', enJson['centerkey-select'])
     cy.upArrow()

diff --git a/cypress/integration/settings-spec.js b/cypress/integration/settings-spec.js
@@ -26,7 +26,7 @@ const settingsMenuListDutchText = [nlJson['settings-language'],
   nlJson['settings-privacy-terms']]
 
 describe('settings page', () => {
-  var firstElementOfTheSettingsMenuList
+  let firstElementOfTheSettingsMenuList
   beforeEach(() => {
     cy.navigateToHomePage()
     searchPage.navigateToSettingsPage()

diff --git a/cypress/integration/special-cases.js b/cypress/integration/special-cases.js
@@ -22,7 +22,7 @@ describe('special cases tests', () => {
 
   it('gallery opens from a non-english article', () => {
     cy.navigateToPageWithoutOnboarding('article/pl/Tupolew_Tu-154/Użytkownicy[24]')
-    cy.wait(500)
+    cy.wait(500) // eslint-disable-line cypress/no-unnecessary-waiting
     articlePage.title().should('have.text', 'Użytkownicy[24]')
     cy.rightArrow()
     cy.enter()

diff --git a/cypress/integration/tips-spec.js b/cypress/integration/tips-spec.js
@@ -14,7 +14,7 @@ const tipsMenuListEnglishText = [enJson['tips-read'],
   enJson['tips-about']]
 
 describe('Tips page', () => {
-  var firstElementOfTheTipsMenuList
+  let firstElementOfTheTipsMenuList
   beforeEach(() => {
     cy.navigateToHomePage()
     searchPage.navigateToTipsPage()

diff --git a/cypress/page-objects/article-page.js b/cypress/page-objects/article-page.js
@@ -35,7 +35,7 @@ export class ArticlePage {
   }
 
   selectOptionFromActionsMenu (option) {
-    var entered = false
+    let entered = false
     cy
       .get('.article-actions-button')
       .each(($el, index, $list) => {