Return early for cover images that are not found #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BookProvider::getCover() was already returning for no pages returned, so this switches to API formatversion 2 and also checks for the `missing` parameter in the first/only returned page. Bug: T370257
|
I think I might merge this if no one minds? Just to clear up the log spam if nothing else (and it'll help a few dozen people who daily try to download books that have incorrect cover images). There are other related issues, but they seem mostly to be needed to be resolved on wikis. e.g. eswikisource are encoding their cover image; I left them a message at https://es.wikisource.org/wiki/Plantilla_discusi%C3%B3n:Proofreadpage_index_template#ws-cover |
Tpt
approved these changes
Aug 19, 2024
|
Yes! |
samwilson
added a commit
that referenced
this pull request
Aug 20, 2024
Because shared-repo images are reported as missing, do not check for that status. And to make things simpler, use the same handling for invalid ones as well, and just check to see if any imageinfo metadata has been returned (that's all we're interested in, after all). This is a follow-up to GH #512. Bug: T372956
samwilson
added a commit
that referenced
this pull request
Aug 20, 2024
Because shared-repo images are reported as missing, do not check for that status. And to make things simpler, use the same handling for invalid ones as well, and just check to see if any imageinfo metadata has been returned (that's all we're interested in, after all). This is a follow-up to GH #512. Bug: T372956
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BookProvider::getCover() was already returning for no pages returned, so this switches to API formatversion 2 and also checks for the
missingparameter in the first/only returned page.Bug: T370257