Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keycloak-principal-transformer for EE 10 and WFLY 27.0.1.Final #160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jessicarod7
Copy link
Contributor

No description provided.

@@ -13,7 +13,7 @@ Compile:
Add a module that contains our custom principal transformer:

bin/jboss-cli.sh
module add --name=org.wildfly.security.examples.keycloak-principal-transformer --resources=/PATH_TO_ELYTRON_EXAMPLES/elytron-examples/keycloak-principal-transformer/target/keycloak-principal-transformer-1.0.0.Alpha1-SNAPSHOT.jar --dependencies=org.wildfly.security.elytron,org.wildfly.extension.elytron,org.keycloak.keycloak-core
module add --name=org.wildfly.security.examples.keycloak-principal-transformer --resources=/PATH_TO_ELYTRON_EXAMPLES/elytron-examples/keycloak-principal-transformer/target/keycloak-principal-transformer-2.0.0.Alpha1-SNAPSHOT.jar --dependencies=org.wildfly.security.elytron,org.wildfly.extension.elytron,org.keycloak.keycloak-adapter-subsystem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check, why was this change needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org.keycloak.keycloak-core isn't a default server module anymore, while the keycloak-adaptor-subsystem is available. Tested this configuration and the demo ran properly.

Copy link
Contributor

@fjuma fjuma Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org.keycloak.keycloak-core wasn't provided by default before. Previously, this example was meant to be used with the Keycloak OIDC adapter. The keycloak-adapter-subsystem is something that was introduced only for migration purposes, it doesn't provide the KeycloakPrincipal class that's used by the custom transformer. I think the steps in the example don't actually make use of the transformer after configuring it. Will take a closer look later to see if we should remove this example or update it a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants