Use ejb client artifact to call ejb basic in oidc-with-identity-propagation #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
tried to write an issue first but explaining with code changes seems to be easier for me.
If you think this is not an issue just delete the PR.
In your article
https://wildfly-security.github.io/wildfly-elytron/blog/wildfly-oidc-identity-propagation/#secure-an-ejb-invoked-by-an-oidc-app-using-a-different-security-domain
you explain how to do identity propagation. Example works as described. But when I only deploy virtual-security-domain-to-domain.ear do not deploy ejb-basic.ear, the example still works.
What should not be the case in my opinion.
When I examined the example the explanation was obvious. On the virtual-security-domain-to-domain.ear the ejb-basic-ejb was included as well. I think there you should only have the ejb-basic-ejb client not the whole ejb (interface and implementation).
If you check my code changes I now create the ejb-basic-ejb-client.jar as well and include this in virtual-security-domain-to-domain.ear. Then I had to change the jndi names a little bit so they could be found. Lastly I had to adjust the cli to connect the ejb-basic.ear virtual security doamain to the BusinessDomain.
Example then behaves the same but if you miss deploying ejb-basic.ear it's not working anymore (as I would expect).
I am correct or did I misunderstood the example?
Best regards
joachim