WFCORE-5279

[jessicarod7]

PoC for elytron-tls-subsystem. Will derive from changes in ELY-2084 of wildfly-elytron. Continuing from #2.

Related issues:

https://issues.redhat.com/browse/WFCORE-5279
https://issues.redhat.com/browse/ELY-2084
https://issues.redhat.com/browse/EAP7-1564

[fjuma]

Hi @cam-rod, I've just done a pass through the build related files and have started with some initial comments. I'm going to do a pass through the Java code next.

[fjuma]

Would be good to update the README to include information about building the corresponding Elytron branch before building the elytron-tls branch.

[jessicarod7]

Yep, will update the README for this project next.

[fjuma]

Might be good to use wildfly-preview-feature-pack here instead since that's a good place for trying out experimental features.

[jessicarod7]

Haven't looked into it before, from my understanding of the docs it acts as a basis for a Preview Galleon installation and also will attempt to update APIs to jakarta.*?

I can give it a try and see if any issues pop up. Also a next step in general would be moving to Jakarta EE dependencies.

[fjuma]

Since WildFly Core / WildFly now rely on Elytron 2.x, it would be good to look at porting the Elytron changes from 1.x to 2.x so that the Elytron and WildFly versions here can be updated.

[jessicarod7]

sounds good, will be part of the second set of updates

[fjuma]

Since the versions in this file were likely initially determined when Martin was working on this, would be good to check the versions to make sure they align with WildFly now.

[Skyllarr]

@cam-rod Was just trying manually and noticed that the server ssl context cannot be added:

 /subsystem=elytron-tls/server-ssl-context=a:add(key-manager=applicationKM)
{
    "outcome" => "failed",
    "failure-description" => {"WFLYCTL0080: Failed services" => {"org.wildfly.security.ssl-context.a" => "Failed to start service
    Caused by: java.lang.NoClassDefFoundError: org/wildfly/security/SecurityFactory
    Caused by: java.lang.ClassNotFoundException: org.wildfly.security.SecurityFactory from [Module \"org.wildfly.elytron-tls-dependency\" from local module loader @821330f (finder: local modu
le finder @6f43c82 (roots: elytron-tls/build/target/wildfly-26.1.1.Final-elytron-tls-1.0.0.Alpha-SNAPSHOT/modules,elytron-tls/build/target/wildfly-26.1.1.Final-elytron-tls-1.0.0.Alp
ha-SNAPSHOT/modules/system/layers/base))]"}},
    "rolled-back" => true
}

I am not sure why yet since you seem to have module org.wildfly.security.elytron-base as dependency.

EDIT: I misread, the elytron-tls module has dependency on elytron-base but elytron-tls-dependency does not

[fjuma]

Just adding some initial comments from a first pass through the Java code. Will take a closer look at the SSL context related code next.

[jessicarod7]

@cam-rod Was just trying manually and noticed that the server ssl context cannot be added:

 /subsystem=elytron-tls/server-ssl-context=a:add(key-manager=applicationKM)
{
    "outcome" => "failed",
    "failure-description" => {"WFLYCTL0080: Failed services" => {"org.wildfly.security.ssl-context.a" => "Failed to start service
    Caused by: java.lang.NoClassDefFoundError: org/wildfly/security/SecurityFactory
    Caused by: java.lang.ClassNotFoundException: org.wildfly.security.SecurityFactory from [Module \"org.wildfly.elytron-tls-dependency\" from local module loader @821330f (finder: local modu
le finder @6f43c82 (roots: elytron-tls/build/target/wildfly-26.1.1.Final-elytron-tls-1.0.0.Alpha-SNAPSHOT/modules,elytron-tls/build/target/wildfly-26.1.1.Final-elytron-tls-1.0.0.Alp
ha-SNAPSHOT/modules/system/layers/base))]"}},
    "rolled-back" => true
}

I am not sure why yet since you seem to have module org.wildfly.security.elytron-base as dependency.

EDIT: I misread, the elytron-tls module has dependency on elytron-base but elytron-tls-dependency does not

@Skyllarr Right, not surprising since elytron-tls-dependency is from one of the original templates. From what I can tell, the subsystem as I got it was based on wildfly-feaure-pack-template with parts of wildfly-grpc-feature-pack mixed in, which probably didn't help me in understanding the code (see the contents of the feature-pack folder in both templates). Once I remove elytron-tls-dependency, it should remove that issue.

[Skyllarr]

@cam-rod Was just trying manually and noticed that the server ssl context cannot be added:

 /subsystem=elytron-tls/server-ssl-context=a:add(key-manager=applicationKM)
{
    "outcome" => "failed",
    "failure-description" => {"WFLYCTL0080: Failed services" => {"org.wildfly.security.ssl-context.a" => "Failed to start service
    Caused by: java.lang.NoClassDefFoundError: org/wildfly/security/SecurityFactory
    Caused by: java.lang.ClassNotFoundException: org.wildfly.security.SecurityFactory from [Module \"org.wildfly.elytron-tls-dependency\" from local module loader @821330f (finder: local modu
le finder @6f43c82 (roots: elytron-tls/build/target/wildfly-26.1.1.Final-elytron-tls-1.0.0.Alpha-SNAPSHOT/modules,elytron-tls/build/target/wildfly-26.1.1.Final-elytron-tls-1.0.0.Alp
ha-SNAPSHOT/modules/system/layers/base))]"}},
    "rolled-back" => true
}

I am not sure why yet since you seem to have module org.wildfly.security.elytron-base as dependency.
EDIT: I misread, the elytron-tls module has dependency on elytron-base but elytron-tls-dependency does not

@Skyllarr Right, not surprising since elytron-tls-dependency is from one of the original templates. From what I can tell, the subsystem as I got it was based on wildfly-feaure-pack-template with parts of wildfly-grpc-feature-pack mixed in, which probably didn't help me in understanding the code (see the contents of the feature-pack folder in both templates). Once I remove elytron-tls-dependency, it should remove that issue.

I see. And yes, the above command is working now and server ssl context can be added.