[ELY-2696] Update 3 tests in PrincipalMappingSuiteChild to call a com… #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrarthonaPaul
approved these changes
Oct 18, 2023
Skyllarr
reviewed
Oct 20, 2023
tests/base/src/test/java/org/wildfly/security/ldap/PrincipalMappingSuiteChild.java
Outdated
Show resolved
Hide resolved
Skyllarr
requested changes
Oct 23, 2023
…mon method in order to remove duplicated code
darranl
approved these changes
Mar 14, 2024
|
I'm not able to re-trigger CI for this one since the last runs took place a little while ago. @PrarthonaPaul Would you be able to check out @map-b's branch, submit a new PR with their commits so we can trigger CI, and then close this PR with a comment that says it's been superseded by your new PR? Thanks! |
Will do! |
|
Superseded by #2115. Thanks @PrarthonaPaul and @map-b! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mon method in order to remove duplicated code
https://issues.redhat.com/browse/ELY-2696