Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-2849] upgrade the commons-io.commons-io dependency from 2.7 to 2… #2226

Merged
merged 1 commit into from
Oct 5, 2024
Merged

[ELY-2849] upgrade the commons-io.commons-io dependency from 2.7 to 2… #2226

merged 1 commit into from
Oct 5, 2024

Conversation

laurastreet
Copy link
Contributor

@laurastreet laurastreet commented Oct 4, 2024 •
edited by ivassile
Loading

@SoniaZaldana
Copy link
Contributor

Thanks @laurastreet! Could you please link the Jira issue in the description?

@luck3y
Copy link
Contributor

luck3y commented Oct 4, 2024

Thanks @laurastreet! One thing to remember is to add a link to the Jira issue in the commit box above.

fjuma
fjuma approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great @laurastreet!

Just a very small comment, it's good practice to include the link to the issue in the issue description (just makes it easy for reviewers to quickly pull up the issue description and see what it was about).

@fjuma fjuma added the +1 FJ label Oct 4, 2024
@ivassile ivassile added the +1 IV label Oct 4, 2024
@PrarthonaPaul
Copy link
Contributor

It seems like there is a CI error that is not related to this PR. @fjuma would you be able to restart the CI jobs?

@fjuma
Copy link
Contributor

fjuma commented Oct 4, 2024

Restarted the jobs.

@fjuma fjuma merged commit fa44472 into wildfly-security:2.x Oct 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivassile ivassile ivassile approved these changes

@fjuma fjuma fjuma approved these changes

@luck3y luck3y luck3y approved these changes

@Skyllarr Skyllarr Awaiting requested review from Skyllarr Skyllarr is a code owner

Assignees
No one assigned
Labels
hacktoberfest-accepted +1 FJ +1 IV
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@laurastreet @SoniaZaldana @luck3y @PrarthonaPaul @fjuma @ivassile