Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce DISCOVERY_CONNECTION_TIMEOUT #499

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Introduce DISCOVERY_CONNECTION_TIMEOUT #499

wants to merge 6 commits into from

Conversation

rachmatowicz
Copy link
Contributor

This PR does the following:

  • reverts three commits for EJBCLIENT-356 which introduced discovery-additional-timeout and eagerNodes
  • add in commit for introducing the connection attempt timeout DISCOVERY_CONNECTION_TIMEOUT
  • add in EJBCLIENT-392 which results in all test cases using AbstractEJBClientTestCase

I will also write a test case to better test the DiscoveryAttempt part of the timeout mechanism before merging - thus this is a draft PR for the time being.

@chengfang chengfang added the Hold label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengfang chengfang Awaiting requested review from chengfang chengfang will be requested when the pull request is marked ready for review chengfang is a code owner

@tadamski tadamski Awaiting requested review from tadamski tadamski will be requested when the pull request is marked ready for review tadamski is a code owner

Assignees
No one assigned
Labels
Hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rachmatowicz @chengfang