[CLOUD-3529] Allow configure ssl-required property

[ruromero]

Fix https://issues.redhat.com/browse/CLOUD-3529

I think the ssl-required parameter should be configurable and default to what was hardcoded before i.e. external

My IDE removed all the trailing spaces which I don't think is a bad thing either.

Signed-off-by: Ruben Romero Montes [email protected]

[wildfly-ci]

Hello, ruromero. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

Available Commands:

/help Display this help text.

/ok-to-test Add the user to the approved list of testers and run tests.

/retest Rerun all tests.

[jfdenise]

@ruromero , we have a CLI way to update the configuration, this is where you should make your change, sed replacement is not expected to evolve.
The external attribute is set there:
https://github.com/ruromero/wildfly-cekit-modules/blob/sslrequired/jboss/container/wildfly/launch/keycloak/added/keycloak.sh#L459
BTW, just a note, I noticed the sslPolicy being set to EXTERNAL: https://github.com/ruromero/wildfly-cekit-modules/blob/sslrequired/jboss/container/wildfly/launch/keycloak/added/keycloak.sh#L777

[ruromero]

Thanks @jfdenise will rollback the changes and update the requested parts of the code.
Are you OK with the functionality proposed?

[jfdenise]

@ruromero , we will need to go through the RFE process in order to add this new env variable. Could you log a CLOUD jira? Would be nice to have detail on the use-case. Thank-you.

[ruromero]

Done @jfdenise https://issues.redhat.com/browse/CLOUD-3529

[ruromero]

@jfdenise added suggested changes

[mwringe]

@jfdenise Any update?

[jfdenise]

@mwringe , I will come back to you with info on when this feature can be integrated in next release. Is the priority of the issue increased?

[jfdenise]

@ruromero @mwringe , after more discussion it appears that this fix needs to be done in https://github.com/jboss-container-images/jboss-eap-modules/tree/7.3.x-legacy/os-eap-sso/added
These are the modules rhpam is using when building docker image.
I logged https://issues.redhat.com/browse/CLOUD-3627 to track it. Would you be able to apply your changes (sed replacement only, no CLI script in legacy modules) to the 7.3.x-legacy? Thank-you.

[ruromero]

@jfdenise PR has been created on jboss-eap-modules too but I don't think this is blocking this PR, is it?
Thanks

[jfdenise]

@ruromero , thank-you. This PR will get merged once we have completed the RFE process for these new env variables.