WFCORE-6995 Allow stability-specific resource transformations for mixed domains #6214
Conversation
pferraro
force-pushed
the
WFCORE-6995
branch
3 times, most recently
from
7be71fb to
e05436b
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Core -> WildFly Preview Integration Build 14066 outcome was FAILURE using a merge of e05436b |
|
Core -> WildFly Preview Integration Build 14067 outcome was FAILURE using a merge of e05436b |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
There has been no activity on this PR for 45 days. It will be auto-closed after 90 days. |
pferraro
force-pushed
the
WFCORE-6995
branch
from
e05436b to
c997c15
Compare
|
Core -> Full Integration Build 14427 outcome was UNKNOWN using a merge of c997c15 |
|
Core -> Full Integration Build 14126 outcome was UNKNOWN using a merge of c997c15 |
|
Core -> WildFly Preview Integration Build 14208 outcome was UNKNOWN using a merge of c997c15 |
|
There has been no activity on this PR for 45 days. It will be auto-closed after 90 days. |
…s using SubsystemModel enumerations.
pferraro
force-pushed
the
WFCORE-6995
branch
from
c997c15 to
aa426d5
Compare
There was a problem hiding this comment.
Just added comments, I do not have the expertise on transformers API to validate the work done here, it should be fine since the BasicResourceTestCase explicitly tests all of those transformations, but I got the impression there is still pending work to do to enable the server to use the expected stability level when it is registering the transformers, that;s still a bit unclear to me
| for (E model : EnumSet.complementOf(EnumSet.of(this.currentSubsystemModel))) { | ||
| ModelVersion version = model.getVersion(); | ||
| ResourceTransformationDescriptionBuilder builder = registration.createResourceTransformationDescriptionBuilder(); | ||
| this.transformation.accept(builder, version); | ||
| TransformationDescription.Tools.register(builder.build(), registration, version); | ||
| } |
There was a problem hiding this comment.
Do we have an example of how to use this class?
I'm not a SME in these transformers and it is too big to digest it easily, but I guess what I cannot see is how this new way to register the transformers will be able to match what we currently have. At this moment, transformers are registered as a chain, with a common builder that registers the transformation from one version to another, however here we are only registering a single version with a specific builder, so I get lost on this.
| @Deprecated(forRemoval = true) | ||
| public static TransformerRegistry create() { | ||
| return new TransformerRegistry(); | ||
| return create(Stability.DEFAULT); | ||
| } |
There was a problem hiding this comment.
What happens with the current usage of this method in our code? Shouldn't we at least force the creation of a transformer registry using a specific Stability level? Otherwise, we will continue using the wrong registry and we won't be able yet to add specific transformations to the subsystems.
| ChainedTransformationDescriptionBuilderFactory factory = KernelAPIVersion.createChainedTransformationDescriptionBuilderFactory(registry); | ||
| registerChainedManagementTransformers(registry, factory); | ||
| registerChainedServerGroupTransformers(registry, factory); | ||
| registerProfileTransformers(registry); | ||
| registerSocketBindingGroupTransformers(registry); | ||
| registerDeploymentTransformers(registry); | ||
| registerSocketBindingGroupTransformers(registry, factory); | ||
| registerDeploymentTransformers(registry, factory); |
There was a problem hiding this comment.
Why we are only changing the Domain Transformers? Shouldn't we also change and adapt in this PR how we are registering the other transformers?
For example, at ElytronSubsystemTransformers we have:
@Override
public void registerTransformers(SubsystemTransformerRegistration registration) {
ChainedTransformationDescriptionBuilder chainedBuilder = TransformationDescriptionBuilder.Factory.createChainedSubystemInstance(registration.getCurrentSubsystemVersion());
What would be the equivalent code to create ChainedTransformationDescriptionBuilder using the current Stability level?
https://issues.redhat.com/browse/WFCORE-6995
Submitting as a draft while I collect feedback and add tests.@yersan Until https://github.com/wildfly/wildfly-legacy-test publishes releases for WildFly versions, it will be impossible to create model transformation tests for COMMUNITY stability.