Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-7162]: Upgrade snakeyaml to 2.4 #6345

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

ehsavoie
Copy link
Contributor

@ehsavoie ehsavoie commented Feb 18, 2025

Upgrading snakeYaml to 2.4:

  • Fix issue #1101: Add option to log duplicate keys (thanks to Matteo Franci)
  • Fix issue #1098: allow HighSurrogate to be the last char in the data window (thanks to Madalin Ilie)
  • Fix issue #1097: Refactor Scanner to improve performance (thanks to David Schlosnagle)
  • Remove external Base64Coder and use provided Base64 (thanks to MithunKhanna)
  • Switch to Java 8 for runtime and support JDK 21

Issue: https://issues.redhat.com/browse/WFCORE-7162

Upgrading snakeYaml to 2.4:
* Fix issue wildfly#1101: Add option to log duplicate keys (thanks to Matteo Franci)
* Fix issue wildfly#1098: allow HighSurrogate to be the last char in the data window (thanks to Madalin Ilie)
* Fix issue wildfly#1097: Refactor Scanner to improve performance (thanks to David Schlosnagle)
* Remove external Base64Coder and use provided Base64 (thanks to MithunKhanna)
* Switch to Java 8 for runtime and support JDK 21

Issue: https://issues.redhat.com/browse/WFCORE-7162

Signed-off-by: Emmanuel Hugonnet <[email protected]>
Copy link
Collaborator

@yersan yersan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehsavoie Job failure is unrelated, so LGTM.

I do not get why in the PR description you have linked the WFLY issues, could you revisit them, those links seem unrelated

@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Feb 19, 2025
@ehsavoie
Copy link
Contributor Author

@yersan I guess it linked the snakeyaml issue numbers to github PR or issues. I fixed the links

@yersan yersan merged commit 58a16a5 into wildfly:main Feb 20, 2025
12 of 13 checks passed
@yersan
Copy link
Collaborator

yersan commented Feb 20, 2025

Thanks @ehsavoie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants