Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a blog post: Debug a provisioned WildFly server with the help of … #663

Merged
merged 1 commit into from
Oct 4, 2024
Merged

add a blog post: Debug a provisioned WildFly server with the help of … #663

merged 1 commit into from
Oct 4, 2024

Conversation

liweinan
Copy link
Contributor

@liweinan liweinan commented Oct 1, 2024

…maven-wildfly-plugin

@liweinan
Copy link
Contributor Author

liweinan commented Oct 1, 2024

@bstansberry @jamezp Could you please help to check if this blog post is proper to be posted here? Thanks!

bstansberry
bstansberry requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@bstansberry bstansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liweinan Very nice!

I made various copy editing suggestions. My only significant feedback is the need to explain a bit about the JBeret channel.

_posts/2024-10-02-debug-with-maven-wildfly-plugin.adoc Outdated Show resolved Hide resolved
_posts/2024-10-02-debug-with-maven-wildfly-plugin.adoc Outdated Show resolved Hide resolved
_posts/2024-10-02-debug-with-maven-wildfly-plugin.adoc Outdated Show resolved Hide resolved
_posts/2024-10-02-debug-with-maven-wildfly-plugin.adoc Outdated Show resolved Hide resolved
_posts/2024-10-02-debug-with-maven-wildfly-plugin.adoc Outdated Show resolved Hide resolved
_posts/2024-10-02-debug-with-maven-wildfly-plugin.adoc Outdated Show resolved Hide resolved
_posts/2024-10-02-debug-with-maven-wildfly-plugin.adoc Outdated Show resolved Hide resolved
_posts/2024-10-02-debug-with-maven-wildfly-plugin.adoc Outdated Show resolved Hide resolved
_posts/2024-10-02-debug-with-maven-wildfly-plugin.adoc Outdated Show resolved Hide resolved
_posts/2024-10-02-debug-with-maven-wildfly-plugin.adoc Outdated Show resolved Hide resolved
@liweinan
Copy link
Contributor Author

liweinan commented Oct 2, 2024

Thanks for the detailed review Brian!

I'll update the text accordingly.

@liweinan liweinan force-pushed the 2024-10-02-debug-with-maven-wildfly-plugin branch from 9463b42 to 664cffa Compare October 2, 2024 10:51
@liweinan
Copy link
Contributor Author

liweinan commented Oct 2, 2024

@bstansberry I have updated the text according to your advice, and I have added a section to explain the jberet-channel-manifest. Could you please help to review it again? IThanks!

@liweinan liweinan force-pushed the 2024-10-02-debug-with-maven-wildfly-plugin branch from 664cffa to 4850edf Compare October 2, 2024 10:55
@liweinan liweinan marked this pull request as draft October 2, 2024 13:07
@liweinan
Copy link
Contributor Author

liweinan commented Oct 2, 2024

I need to add some more contents.

@liweinan liweinan force-pushed the 2024-10-02-debug-with-maven-wildfly-plugin branch from 4850edf to 7ef8e21 Compare October 2, 2024 13:42
@liweinan
Copy link
Contributor Author

liweinan commented Oct 2, 2024

done: finished adding the content related with manifest.

@liweinan liweinan marked this pull request as ready for review October 2, 2024 13:43
@liweinan liweinan force-pushed the 2024-10-02-debug-with-maven-wildfly-plugin branch from 7ef8e21 to 7a91825 Compare October 2, 2024 13:45
bstansberry
bstansberry requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@bstansberry bstansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liweinan for the updates. There's one more rendering issue.

@liweinan liweinan force-pushed the 2024-10-02-debug-with-maven-wildfly-plugin branch from 7a91825 to 868ae1b Compare October 3, 2024 00:57
@liweinan
Copy link
Contributor Author

liweinan commented Oct 3, 2024

@bstansberry Yes sir!

jamezp
jamezp reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor comments, but otherwise looks good.

_posts/2024-10-02-debug-with-maven-wildfly-plugin.adoc Outdated Show resolved Hide resolved
_posts/2024-10-02-debug-with-maven-wildfly-plugin.adoc Outdated Show resolved Hide resolved
_posts/2024-10-02-debug-with-maven-wildfly-plugin.adoc Outdated Show resolved Hide resolved
@liweinan
Copy link
Contributor Author

liweinan commented Oct 4, 2024

@jamezp @bstansberry Thanks for the detailed comments! I'll modify the text accordingly.

@liweinan liweinan force-pushed the 2024-10-02-debug-with-maven-wildfly-plugin branch 2 times, most recently from 4b331d6 to 2dd9c5d Compare October 4, 2024 10:47
@liweinan liweinan force-pushed the 2024-10-02-debug-with-maven-wildfly-plugin branch from 2dd9c5d to 9052d56 Compare October 4, 2024 10:47
@liweinan
Copy link
Contributor Author

liweinan commented Oct 4, 2024

@bstansberry @jamezp I have updated the text according to your suggestions. Please let me know if anything else need to be changed :D

bstansberry
bstansberry approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@bstansberry bstansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamezp This LGTM, and I've verified it renders correctly. Please ping me in zulip when you've reviewed it and I'll do the GitHub action thing to move it to today's date.

@github-actions github-actions bot mentioned this pull request Oct 4, 2024
Merged
@jamezp jamezp merged commit 9052d56 into wildfly:main Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamezp jamezp jamezp approved these changes

@bstansberry bstansberry bstansberry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liweinan @bstansberry @jamezp