Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-16532 [Preview] elytron-oidc-client: add ability to configure additional scope for authentication request #17790

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

PrarthonaPaul
Copy link

@PrarthonaPaul PrarthonaPaul commented Apr 3, 2024

Analysis doc: wildfly/wildfly-proposals#527
WFLY Issue: https://issues.redhat.com/browse/WFLY-16532
Related ELY Issue: https://issues.redhat.com/browse/ELY-2574
Depends on: wildfly-security/wildfly-elytron#1925
Depends on: #17705

This PR supersedes #17785. It includes a fix for an error that occurred in testsuite/integration/elytron due to incorrect stability levels.


<--- THIS SECTION IS AUTOMATICALLY GENERATED BY WILDFLY GITHUB BOT. ANY MANUAL CHANGES WILL BE LOST. --->

Wildfly issue links:

<--- END OF WILDFLY GITHUB BOT REPORT --->

More information about the wildfly-bot[bot]

Prarthona Paul and others added 5 commits April 2, 2024 11:06
@@ -618,6 +620,7 @@
<jboss-maven-dist/>
<jboss-fork-embedded>${galleon.fork.embedded}</jboss-fork-embedded>
<optional-packages>passive+</optional-packages>
<config-stability-level>preview</config-stability-level>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed!

@@ -488,6 +490,7 @@
<jboss.inst>${wildfly.dir}</jboss.inst>
<module.path>${wildfly.dir}/modules</module.path>
<node0>${node0}</node0>
<embedded.server.stability>preview</embedded.server.stability>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I think we can use <embedded.stability>${embedded.server.stability}</embedded.stability>.

@@ -13,7 +13,7 @@
<configuration>
<property name="javaVmArguments">${server.jvm.args}</property>
<property name="serverConfig">${jboss.server.config.file.name:standalone.xml}</property>
<property name="jbossArguments">${jboss.args}</property>
<property name="jbossArguments">${jboss.args} --stability=${embedded.server.stability}</property>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then this would be ${embedded.stability}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@wildfly-bot wildfly-bot bot requested a review from fjuma April 3, 2024 19:43
@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Apr 3, 2024
…due to incorrect stability level for wildfly-maven-plugin:execute-commands
@fjuma fjuma added Feature PR provides a new feature Critical Doesn't block a release but deserves higher priority than most. Use sparingly. 32.x labels Apr 3, 2024
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding my approval on this one. Will keep an eye on CI.

@bstansberry bstansberry mentioned this pull request Apr 4, 2024
@bstansberry
Copy link
Contributor

#17792 should fix the MPScriptTestCase failures

@darranl darranl merged commit 3d90fe2 into wildfly:main Apr 4, 2024
9 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical Doesn't block a release but deserves higher priority than most. Use sparingly. deps-ok Dependencies have been checked, and there are no significant changes Feature PR provides a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants