-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFLY-16532 [Preview] elytron-oidc-client: add ability to configure additional scope for authentication request #17790
Conversation
…to use optional client scopes for multipleClientScpes test
…r to enumerate schema versions
…c.json file to ensure that subsystem configuration still takes precedence over deployment configuration
@@ -618,6 +620,7 @@ | |||
<jboss-maven-dist/> | |||
<jboss-fork-embedded>${galleon.fork.embedded}</jboss-fork-embedded> | |||
<optional-packages>passive+</optional-packages> | |||
<config-stability-level>preview</config-stability-level> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed!
ce0d33f
to
6be31eb
Compare
@@ -488,6 +490,7 @@ | |||
<jboss.inst>${wildfly.dir}</jboss.inst> | |||
<module.path>${wildfly.dir}/modules</module.path> | |||
<node0>${node0}</node0> | |||
<embedded.server.stability>preview</embedded.server.stability> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, I think we can use <embedded.stability>${embedded.server.stability}</embedded.stability>
.
@@ -13,7 +13,7 @@ | |||
<configuration> | |||
<property name="javaVmArguments">${server.jvm.args}</property> | |||
<property name="serverConfig">${jboss.server.config.file.name:standalone.xml}</property> | |||
<property name="jbossArguments">${jboss.args}</property> | |||
<property name="jbossArguments">${jboss.args} --stability=${embedded.server.stability}</property> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And then this would be ${embedded.stability}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
6be31eb
to
8f197f5
Compare
…due to incorrect stability level for wildfly-maven-plugin:execute-commands
8f197f5
to
e1918eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding my approval on this one. Will keep an eye on CI.
#17792 should fix the MPScriptTestCase failures |
Analysis doc: wildfly/wildfly-proposals#527
WFLY Issue: https://issues.redhat.com/browse/WFLY-16532
Related ELY Issue: https://issues.redhat.com/browse/ELY-2574
Depends on: wildfly-security/wildfly-elytron#1925
Depends on: #17705
This PR supersedes #17785. It includes a fix for an error that occurred in testsuite/integration/elytron due to incorrect stability levels.
<--- THIS SECTION IS AUTOMATICALLY GENERATED BY WILDFLY GITHUB BOT. ANY MANUAL CHANGES WILL BE LOST. --->
<--- END OF WILDFLY GITHUB BOT REPORT --->
More information about the wildfly-bot[bot]