Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guarantor and view loan #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

guarantor and view loan #20

wants to merge 1 commit into from

Conversation

bosstha
Copy link
Collaborator

@bosstha bosstha commented Jul 3, 2018

TDD for guarantor approve and user view single and multiple loans.

@bosstha bosstha requested a review from wilforlan July 3, 2018 13:24
Copy link
Owner

@wilforlan wilforlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, make sure that your file is properly indented.


it ('POST should return a status of 201 Created', function () {
frisby.globalSetup({
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect Flow, you should be getting the token from the login endpoint. So I can test automatically.

password: "miracle"
})
.expect('status', 201);
.get('http://localhost:3000/loans/approve/,5b3b249b0d216645b40447aa')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the comma here before the id ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants