Sommy #22
Open
Sommy #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilforlan
reviewed
Jul 4, 2018
| @@ -13,12 +13,12 @@ function RequestLoan (req, res){ | |||
| // check if guarantor id and user id is the same | |||
| // both cant be the same, because a user cannot be his own guarantor | |||
|
|
|||
| if (loanObject.userId === loanObject.guarantorId) return res.json({'status': false, | |||
| if (loanObject.userId === loanObject.guarantorId) return res.status(403).json({'status': false, | |||
wilforlan
requested changes
Jul 4, 2018
|
Okay.. This is what i understand from your review. You don't want me to set request headers by myself, it should be set by the login test suite and then my test uses it to pass or fail.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test files for loanRequest and loanRepaid....
Edited function requestLoan to send specific status codes.. And also edited function repaidLoan, added checks for double entry and also added appropriate response status codes.