Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to exit after launch #690

Closed
wants to merge 2 commits into from

Conversation

benjamingwynn
Copy link
Contributor

Using this option fixes #595 by proxy of spawning a new instance on the current desktop.

I imagine cleaning up Browserosaurus can also help conserve memory usage on those systems with little of it, at the cost of startup time.

Keep in mind if this option is set during development, Browserosaurus will exit and you'll have to restart it on the command line to use it as the default HTTP handler; but in production this would seamlessly spin up the app when the user clicks a link.

This returns a promise from openApp which could perhaps be used for more extensive error handling in the future.

Using this option fixes will-stone#595 by proxy of spawning a new instance on the
current desktop.

I imagine cleaning up Browserosaurus can also help conserve memory usage
on those systems with little of it, at the cost of startup time.

Keep in mind if this option is set during development, Browserosaurus
*will* exit and you'll have to restart it on the command line to use
it as the default HTTP handler; but in production this would seamlessly
spin up the app when the user clicks a link.

This returns a promise from `openApp` which could perhaps be used for
more extensive error handling in the future.
@will-stone
Copy link
Owner

Thanks for being enthusiastic about this but this must be incredibly slow, no? B is an Electron app, there’s no way people would put with this feature, surely.

@will-stone
Copy link
Owner

will-stone commented May 23, 2024

Again, thanks for being passionate enough about the project to go digging in the source, but I won’t be merging this feature. Next time I would ask you wait for a reply before spending time on this. But on the bright side, you now have a fork that behaves how you’d like it to ☺️ If you’re able to solve the original problem with the fullscreen app, then I’d be happy to look at that.

@will-stone will-stone closed this May 23, 2024
@benjamingwynn
Copy link
Contributor Author

Hey @will-stone ! Thanks for getting back to me so quickly - no problem that you don't want this upstream

Next time I would ask you wait for a reply before spending time on this.

No worries on that front! I was looking to build my own experience with redux and macos electron apps

But on the bright side, you now have a fork that behaves how you’d like it to

Indeed, if I could get it built 😛

Sorry for the obvious question, but when I was trying to package the application into a .app to test I was getting an obscure signing error - do I need to get my own Apple developer keys or something to get this working? I'm assuming you either keep these or have these in a CI/CD pipeline for official B builds

If you’re able to solve the original problem with the fullscreen app, then I’d be happy to look at that

I'd be willing to look at this but it's probably beyond my ability, and as far as I know this hasn't gotten an upstream bug report in Electron yet.

Interestingly, vscode's code CLI wrapper doesn't seem to have this problem when spawning a new vscode instance, so perhaps the solution for B would be a similar wrapper program? (Just thinking aloud at this point)

@will-stone
Copy link
Owner

To distribute you’ll need to pay for an Apple Developer account.

You can run the package command to get a .app for your Mac’s architecture though and that should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working with links from Full Screen apps and multiple workspaces/desktops (need to restart app frequently)
2 participants