build: decouple secp256 tests from BUILD_TESTS #31
+39
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willcl-ark
force-pushed
the
disable-secp-tests-split
branch
2 times, most recently
from
61d57fb to
38049bb
Compare
These tests add a minimum of a few minutes to the unit test runtime, and
at worst see runtime double.
Decouple them from ${BUILD_TESTS} so that they can be more selectively
enabled/disabled.
willcl-ark
force-pushed
the
disable-secp-tests-split
branch
from
38049bb to
a6cc66a
Compare
This workflow job detects whether the secp256k1 subtree was updated, and if it was will build and run the secp256k1 unit tests. These are disabled by default (in other CI jobs), as they double the runtime needed, and rarely change.
willcl-ark
force-pushed
the
disable-secp-tests-split
branch
from
a6cc66a to
5ad028f
Compare
willcl-ark
force-pushed
the
master
branch
23 times, most recently
from
41c30ee to
2fcab0a
Compare
willcl-ark
force-pushed
the
master
branch
2 times, most recently
from
b78454f to
70103cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests add a minimum of a few minutes to the unit test runtime, and
at worst see runtime double.
Decouple them from ${BUILD_TESTS} so that they can be more selectively
enabled/disabled.