Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#163] Added support for translation extractors for JS #238

Closed
wants to merge 16 commits into from
+198 −1
Closed

[#163] Added support for translation extractors for JS #238

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6b4463a
[#163] Added support for translation extractors for JS and Coffeescri…
jcchavezs Jun 10, 2016
3743264
[#163] Fixed a bug in the declaration of extractors in Resources/conf…
jcchavezs Jun 10, 2016
7a0bc62
[#163] Added documentation for the extractors.
jcchavezs Jun 10, 2016
7f3b2ab
[#163] Fixed a bug when using the finder in order to make the extract…
jcchavezs Jun 18, 2016
9f3d600
[#163] Fixes based on PR comments.
jcchavezs Oct 21, 2016
32f738c
[#163] Fixed a bug in the regex for extracting transChoice.
jcchavezs Oct 21, 2016
5aaac48
[#163] Fixed compatibility with PHP 5.3.
jcchavezs Oct 21, 2016
4137824
[#163] Fixes based on PR comment
jeremy-richard Jan 29, 2018
4b1f6c4
[#163] Fixes JsExtractorTest based on PR comment
jeremy-richard Jan 29, 2018
d57b413
[#163] Fixes services as Finder isn't one
jeremy-richard Jan 29, 2018
e33a819
[#163] Update CoffeeExtractorTest and JsExtractorTest
jeremy-richard Jan 29, 2018
f243f89
[#163] Fixes based on PR comments.
jeremy-richard Jan 31, 2018
fb372e7
Add missing break in all js and coffee files
jeremy-richard Feb 12, 2018
0ee29c6
Here Comes a New Challenger : FrontendExtractor
jeremy-richard Feb 14, 2018
2b2c5d4
Fix Call to undefined method ArrayNodeDefinition::arrayPrototype()
jeremy-richard Feb 14, 2018
e6dba39
Fixes based on PR comments
jeremy-richard Feb 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Call to undefined method ArrayNodeDefinition::arrayPrototype()
@jeremy-richard
jeremy-richard committed Feb 14, 2018
commit 2b2c5d475eec829c08828b7308f14605d11101a1
2 changes: 1 addition & 1 deletion DependencyInjection/Configuration.php
View file
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@ public function getConfigTreeBuilder()
->end()
->end()
->arrayNode('frontend')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather name it extractor

->arrayPrototype()
->prototype('array')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we actually need an array of configurations here ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your comment, no. We can use differents services.

->children()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation should use 4 spaces

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

->arrayNode('extensions')
->prototype('scalar')