Server offline landing clean #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for automatic port forwarding of trace-server api calls when using remote. Signed-off-by: Will Yang <[email protected]> Server offline landing view Creates a new webview in the trace explorer. This simply displays a button that allows the user to start the server if the front-end detects the server is offline. This: 1. Provides a more intuitive user experience 2. Stops the user from sendinding some requests when the server is not online which causes the application to break Changes here are tied to changes in the theia-trace-extension repository. Signed-off-by: William Yang <[email protected]>
williamsyang-work
force-pushed
the
server-offline-landing-clean
branch
from
830f591 to
ad735b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.