Modbus Remote control - Two new mode names #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have been trying to work on adding proper black support #1143 (comment) to keep the formatting consistent. This PR is now a little messed up. Would you be able to resubmit it with the changes you have made. Thanks |
|
Sure. It is small change and I can redo it quickly. Sorry again for formating. I returned from holiday and somehow forget to be careful on commit compare 😞 |
PatrikTrestik
force-pushed
the
fix/modbus_remote_VPP_sensors
branch
from
599ef4b to
c8232eb
Compare
|
@wills106 Cleaned up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is new (or newly found) documentation for Modbus Remote control: SolaX_VPP function Definition of ESS
Adding two missing modes and changing existing for clarity.
From documentation it is obvious that SolaX developers changed something or we do not get clear view how it should work.
This new description shows some light. I'm testing it and will prepare PR once I have working version.