Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bitwig-studio has in-housed downloads #1079

Merged
merged 4 commits into from
May 17, 2024
Merged

fix: bitwig-studio has in-housed downloads #1079

merged 4 commits into from
May 17, 2024

Conversation

philclifford
Copy link
Member

@philclifford philclifford commented May 16, 2024 •
edited
Loading

closes #1078

@philclifford philclifford mentioned this pull request May 16, 2024
Closed
@philclifford philclifford marked this pull request as draft May 16, 2024 01:04
@philclifford
Copy link
Member Author

philclifford commented May 16, 2024 •
edited
Loading

Ah - redirects no longer working!
the redirected URL need not to be trimmed and a filename provided for the download to work.
Until the new deb-get after merge is in the users' hands the package definition will still fail though. So a subsequent commit will be added to include the function definition in the package. This commit can be reverted in/after a release.

@philclifford
feat(bitwig-studio): Get the redirect URL
5ab6041 
this provides a URL we(I?) can open in a browser, but deb-get fails
@philclifford
fix: provide output filename to downloader
723acad
@philclifford
fix(bitwig-studio): Copy required function into package definition
194f31b 
this can be reverted once it is published in a deb-get release
@philclifford philclifford marked this pull request as ready for review May 16, 2024 02:10
@philclifford
Copy link
Member Author

Test failure is curious: I guess they're missing a dependency that I have installed. It installed with out issue on this 22.04 potato.

BitWig Studio
  Package:	bitwig-studio
  Repository:	99-local
  Updater:	deb-get
  Installed:	5.1.9
  Published:	5.1.9

@philclifford
Copy link
Member Author

removing it suggest why the test might have failed

The following packages will be REMOVED
bitwig-studio libxcb-icccm4:i386 libxcb-util1:i386 libxcb-xinput0:i386 libxcb-xkb1:i386 libxkbcommon-x11-0:i386

I bet it's those 32-bit packages and the runner not being able/configured to support i386

@flexiondotorg
Copy link
Member

Adding dpkg --add-architecture i386 before the tests run should sort that.

@flexiondotorg flexiondotorg merged commit 238a6b5 into wimpysworld:main May 17, 2024
1 of 2 checks passed
@philclifford philclifford deleted the fix-bitwig branch May 18, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexiondotorg flexiondotorg flexiondotorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot update and upgrade apps after bitwig-studio including
2 participants
@philclifford @flexiondotorg