Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip xy coordinates in ENVI files #156

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Flip xy coordinates in ENVI files #156

merged 5 commits into from
Oct 31, 2023

Conversation

zsteinmetz
Copy link
Collaborator

Fixes #150

@zsteinmetz
Copy link
Collaborator Author

@wincowgerDEV, could you maybe have a second look if the coordinates are correct now? No worries, builds are failing only because I haven't updated the tests yet ..

Copy link
Owner

@wincowgerDEV wincowgerDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code updates look good to me with a quick look but the heatmap output for sig_noise of the tiny map should reveal a blob in the center.

test <- read_any(read_extdata("CA_tiny_map.zip"))

heatmap_spec(test, z = sig_noise(test, metric = "sig_times_noise"))

This is what it looks like right now:
image

This is what it used to look like:
image

The two should really just be mirror images of one another but it looks like the alignment is off somehow.

@wincowgerDEV
Copy link
Owner

Not quite sure how to write a test for this but I think I got it figured out, the dcast needed to be updated too. Committing soon.
image

@wincowgerDEV
Copy link
Owner

I think we got it now.

@zsteinmetz
Copy link
Collaborator Author

Thanks, Win!

@zsteinmetz zsteinmetz merged commit 3812966 into main Oct 31, 2023
7 checks passed
@zsteinmetz zsteinmetz deleted the flip-envi-coords branch October 31, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: XY coordinates flipped in maps
2 participants