Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nix documentation + flake cleanups #4662

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

uael
Copy link
Contributor

@uael uael commented Nov 7, 2024

Important

Add Nix documentation and clean up flake.nix for streamlined development and build processes.

  • Documentation:
    • Add Nix usage instructions to frontend/README_DEV.md, including development and update steps.
    • Add Nix section to README.md for running local dev setup.
  • Flake Cleanups:
    • Update flake.nix to use rust-bin.stable.latest.default instead of rust-bin.beta.latest.default.
    • Remove redundant environment variables from flake.nix.
    • Add wm-reset script to flake.nix for database reset.
    • Refactor RUSTY_V8_ARCHIVE definition in flake.nix for clarity.

This description was created by Ellipsis for 7db5fdb. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7db5fdb in 1 minute and 27 seconds

More details
  • Looked at 213 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. flake.nix:67
  • Draft comment:
    Ensure that the DATABASE_URL environment variable is documented in the frontend/README_DEV.md to reflect its new location in the devShell block.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. flake.nix:123
  • Draft comment:
    Ensure that the new method for fetching RUSTY_V8_ARCHIVE is correct and efficient. The previous fetch_librusty_v8 function was removed, so verify that the new approach works as intended.
  • Reason this comment was not posted:
    Comment did not seem useful.
3. flake.nix:135
  • Draft comment:
    Ensure that the new method for fetching RUSTY_V8_ARCHIVE is correct and efficient. The previous fetch_librusty_v8 function was removed, so verify that the new approach works as intended.
  • Reason this comment was not posted:
    Marked as duplicate.
4. flake.nix:136
  • Draft comment:
    Ensure that the new method for fetching RUSTY_V8_ARCHIVE is correct and efficient. The previous fetch_librusty_v8 function was removed, so verify that the new approach works as intended.
  • Reason this comment was not posted:
    Marked as duplicate.
5. flake.nix:58
  • Draft comment:
    The script wm in flake.nix duplicates functionality found in frontend/.devcontainer.json at line 23. Consider using or extending the existing command instead.

  • postStartCommand (.devcontainer.json)

  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_fLY1FKkMLOweFbMP


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

auto-merge was automatically disabled November 7, 2024 14:51

Head branch was pushed to by a user without write access

@rubenfiszel rubenfiszel changed the title feat: add nix documentation + flake cleanups add nix documentation + flake cleanups Nov 7, 2024
@rubenfiszel rubenfiszel merged commit 9022d4e into windmill-labs:main Nov 7, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@uael uael deleted the uael/flake branch November 7, 2024 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants