Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUPRULE-1041 jakarta cdi to quarkus rules #1040

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

PhilipCattanach
Copy link
Contributor

Hi Mark,

I have created this PR to try to create an equivalent ruleset to quarkus/java-ee/cdi-to-quarkus.windup.xml but to work for the jakarta rather than javax classes.
The tests fail for the last 2 rules in the ruleset so I assumed I had to add the jakarta classes in order for them to work.
I have done that copying the example from https://github.com/windup/windup-rulesets/pull/630/files that Juanma implemented.
However those final two rules still aren't working and I don't know why.

Would you mind investigating please?

m-brophy and others added 4 commits December 4, 2023 18:53
@m-brophy m-brophy changed the title WINDUPRULE-1041 Work in progress WINDUPRULE-1041 jakarta cdi to quarksu rules Jan 16, 2024
@m-brophy m-brophy changed the title WINDUPRULE-1041 jakarta cdi to quarksu rules WINDUPRULE-1041 jakarta cdi to quarkus rules Jan 16, 2024
@m-brophy m-brophy added auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch and removed Work in Progress/For Discussion Only labels Jan 16, 2024
@m-brophy m-brophy merged commit 31dd0b8 into windup:master Jan 16, 2024
27 checks passed
@mrizzi mrizzi added the auto-backport Set the PR for being backported label Jan 16, 2024
github-actions bot pushed a commit that referenced this pull request Jan 16, 2024
* WINDUPRULE-1041 Work in progress

* Update jakarta-cdi-to-quarkus.windup.test.xml

attempt to fix test failures

* Winduprule 1041 (#9)

* cgi to quarkus rules for jakarta classes

* remove failing groovy tests

---------

Co-authored-by: Phil Cattanach <[email protected]>
Co-authored-by: Mark Brophy <[email protected]>
(cherry picked from commit 31dd0b8)
Copy link

💚 All backports created successfully

Status Branch Result
releases/6.3.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

mrizzi pushed a commit that referenced this pull request Jan 17, 2024
* WINDUPRULE-1041 Work in progress

* Update jakarta-cdi-to-quarkus.windup.test.xml

attempt to fix test failures

* Winduprule 1041 (#9)

* cgi to quarkus rules for jakarta classes

* remove failing groovy tests

---------

Co-authored-by: Phil Cattanach <[email protected]>
Co-authored-by: Mark Brophy <[email protected]>
(cherry picked from commit 31dd0b8)

Co-authored-by: Phil Cattanach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants