Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove dependency on nvim-treesitter. Needed for nvim-treesitter rewrite. Requires Neovim >= 0.9.4 #171

Merged
merged 1 commit into from
May 18, 2024

Conversation

folke
Copy link
Contributor

@folke folke commented May 17, 2024

This PR removes the dependency on nvim-treesitter and uses Neovim's treesitter methods.

Without this PR, nvim-ts-autotag will be broken once the nvim-treesitter rewrite is released.

Some tests related to eruby seems to fail, but I'm not sure this is due to these code changes.

@folke folke mentioned this pull request May 17, 2024
@PriceHiller
Copy link
Collaborator

Hi @folke, I've begun maintaining a fork over @ https://github.com/PriceHiller/nvim-ts-autotag/ that should be compatible with the latest breaking changes upstream until windwp hopefully comes back. It seems they've been inactive over here for a few months.

There's been a few minor configuration changes to how setup is done, but nothing major.

You may want to give it a shot until windwp is back 🙂.

@folke
Copy link
Contributor Author

folke commented May 18, 2024

oh nice. Maybe you should also open a pull request in this repo for more visibility?
Then I can close this one

@PriceHiller
Copy link
Collaborator

oh nice. Maybe you should also open a pull request in this repo for more visibility?

It's more than just nvim-treesitter, it's quite a bit wrapped up in it including other PRs that sat in limbo.

I guess I should open it anyways for tracking.

Will do here shortly.

@PriceHiller
Copy link
Collaborator

PriceHiller commented May 18, 2024

Will do here shortly.

Done.

@folke
Copy link
Contributor Author

folke commented May 18, 2024

Closing in favor of #173

Will start testing your fork! :)

@folke folke closed this May 18, 2024
@windwp windwp reopened this May 18, 2024
@windwp
Copy link
Owner

windwp commented May 18, 2024

@folke I like your PR. Thank

@windwp windwp merged commit aeb7090 into windwp:main May 18, 2024
1 check failed
@folke
Copy link
Contributor Author

folke commented May 18, 2024

oh awesome, thanks!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants