Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to be lazy loaded on InsertEnter #212

Merged
merged 1 commit into from
Aug 27, 2024
Merged

feat: allow to be lazy loaded on InsertEnter #212

merged 1 commit into from
Aug 27, 2024

Conversation

lopi-py
Copy link
Contributor

@lopi-py lopi-py commented Aug 25, 2024

No description provided.

@PriceHiller
Copy link
Collaborator

Hello, thanks for the PR!

I'm assuming there's a performance problem that prompted this PR? To my knowledge nvim-ts-autotag is pretty quick on load, there really shouldn't be much of a startup impact at all (around ~5 ms).

If you can demonstrate a significant startup performance hit, I'm open to merging this (assuming lazy loading on InsertEnter works, of course).

@lopi-py
Copy link
Contributor Author

lopi-py commented Aug 27, 2024

I lazy/defer load nvim-treesitter because the typescript parser is slow (not shown in the startup time but the delay is very noticeable) when I open a buffer, but nvim-ts-autotag forces nvim-treesitter to load
image
I definitely tested this before opening a PR.

@PriceHiller
Copy link
Collaborator

Ah, that makes sense. Thanks again for the PR!

@PriceHiller PriceHiller merged commit e239a56 into windwp:main Aug 27, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants