Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of non-Latin characters #27

Merged
merged 3 commits into from
May 17, 2016
Merged

Conversation

Amice13
Copy link
Contributor

@Amice13 Amice13 commented May 17, 2016

Current solution throws an error if Cyrillic characters are used for labels.

Other languages can be supported with changing of database collation to utf8_general_ci, adding UTF-8 charset to HTML pages and extending regex validation in fileManager.php

@hermannschwaerzlerUIBK
Copy link

Hi Kyrylo,
as far as I can tell, this is related to issue #24.
Thanks for you proposed solution for that problem!
Is there a reason why you are using A-Za-z\p{Ll}\p{Lt}\p{Cyrillic} (instead of the generic \p{L} or \p{Letter}) and 0-9 (instead of \p{N} or \p{Number}) in your regex?
I think using the generic RegEx Unicode Categories would solve the problem not only for cyrillic languages but for any language!

Greetings
Hermann

@Amice13
Copy link
Contributor Author

Amice13 commented May 17, 2016

Nope. No reasons. I just tried to find the solution for Cyrillic symbols. So \p{L} and \p{N} are much better.

@winteram winteram merged commit 99fb9ed into winteram:master May 17, 2016
@winteram
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants