Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added better log viewing #1303

Merged
merged 13 commits into from
Feb 13, 2025
Merged

Added better log viewing #1303

merged 13 commits into from
Feb 13, 2025

Conversation

jaxwilko
Copy link
Member

@jaxwilko jaxwilko commented Feb 10, 2025

Relies on wintercms/storm#204

This change adds a fully backwards compatible "v2" log viewer that allows of unrolling of all previous exceptions.

Screenshot 2025-02-12 at 11 07 32 PM

It also adds snippets for each frame in the call stack :)

@jaxwilko
Copy link
Member Author

@wintercms/maintainers if anybody fancied helping test this that would be super helpful, I want to make sure all different types of exceptions are caught and handled properly :)

@jaxwilko
Copy link
Member Author

image

@jaxwilko
Copy link
Member Author

Now extra information about the enviroment is recorded and displayed to the user:
image

In addition, if the request is in the web context, some of the request data is captured and displayed:
image

If there are more than 1 exception, they are now sortable too:
image

@jaxwilko jaxwilko requested a review from LukeTowers February 12, 2025 13:01
@LukeTowers LukeTowers added this to the 1.2.8 milestone Feb 13, 2025
@LukeTowers LukeTowers added the enhancement PRs that implement a new feature or substantial change label Feb 13, 2025
LukeTowers pushed a commit to wintercms/storm that referenced this pull request Feb 13, 2025
@LukeTowers LukeTowers merged commit 7951a22 into develop Feb 13, 2025
13 checks passed
@LukeTowers LukeTowers deleted the wip/better-error-logging branch February 13, 2025 05:13
@damsfx
Copy link
Contributor

damsfx commented Feb 13, 2025

@jaxwilko @LukeTowers The new view in the log manager is simply amazing!
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that implement a new feature or substantial change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants