Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop mls::conversation::export module [WPB-15585] #947

Closed

Conversation

SimonThormeyer
Copy link
Contributor

What's new in this PR

See title


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

This is where `get_client_ids()` and `export_secret_key()` are
implemented, so this is the place to be for their unit tests.
@SimonThormeyer SimonThormeyer force-pushed the simon/refactor/refactor-conversation-WPB-15585 branch from e8f7b73 to 3e045a0 Compare March 4, 2025 09:00
@SimonThormeyer SimonThormeyer marked this pull request as ready for review March 4, 2025 09:02
@SimonThormeyer SimonThormeyer requested a review from a team as a code owner March 4, 2025 09:02
Copy link

github-actions bot commented Mar 4, 2025

🐰 Bencher Report

Branchsimon/refactor/refactor-conversation-WPB-15585
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencymilliseconds (ms)
Commit add f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
18.79 ms
Commit add f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.93 ms
Commit add f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
9.45 ms
Commit add f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
12.01 ms
Commit add f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
14.95 ms
Commit add f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
17.05 ms
Commit add f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
981.54 ms
Commit add f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
6.79 ms
Commit add f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
84.65 ms
Commit add f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
219.45 ms
Commit add f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
428.97 ms
Commit add f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
668.39 ms
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
116.13 ms
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
28.21 ms
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
45.71 ms
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
60.71 ms
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
79.18 ms
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
94.37 ms
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
🚷 view threshold
18.67 ms
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
🚷 view threshold
114.82 ms
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
🚷 view threshold
35.88 ms
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
🚷 view threshold
56.57 ms
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
🚷 view threshold
75.36 ms
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
🚷 view threshold
95.07 ms
Commit remove f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
27.56 ms
Commit remove f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.86 ms
Commit remove f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
8.98 ms
Commit remove f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
11.84 ms
Commit remove f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
17.50 ms
Commit remove f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
21.73 ms
Commit remove f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
30.57 ms
Commit remove f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
136.52 ms
Commit remove f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
115.97 ms
Commit remove f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
93.57 ms
Commit remove f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
71.53 ms
Commit remove f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
50.74 ms
Commit update f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
135.89 ms
Commit update f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.90 ms
Commit update f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
33.30 ms
Commit update f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
59.08 ms
Commit update f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
85.73 ms
Commit update f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
110.81 ms
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 96.59091% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (516f701) to head (befb1c5).

Files with missing lines Patch % Lines
crypto/src/mls/conversation/mod.rs 96.59% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #947      +/-   ##
==========================================
+ Coverage   79.76%   79.86%   +0.09%     
==========================================
  Files         114      113       -1     
  Lines       21056    21045      -11     
==========================================
+ Hits        16796    16807      +11     
+ Misses       4260     4238      -22     
Files with missing lines Coverage Δ
crypto/src/mls/conversation/mod.rs 94.54% <96.59%> (+0.53%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516f701...befb1c5. Read the comment docs.

The (probably) only reason we had this in the past was to bundle the
duplicated APIs of conversation methods in a single place. Having removed
the duplication allows us to drop the module.
@SimonThormeyer SimonThormeyer force-pushed the simon/refactor/refactor-conversation-WPB-15585 branch 2 times, most recently from c82b73d to befb1c5 Compare March 4, 2025 09:53
@SimonThormeyer
Copy link
Contributor Author

Will be done in #948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants