-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: drop mls::conversation::export
module [WPB-15585]
#947
refactor: drop mls::conversation::export
module [WPB-15585]
#947
Conversation
This is where `get_client_ids()` and `export_secret_key()` are implemented, so this is the place to be for their unit tests.
e8f7b73
to
3e045a0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #947 +/- ##
==========================================
+ Coverage 79.76% 79.86% +0.09%
==========================================
Files 114 113 -1
Lines 21056 21045 -11
==========================================
+ Hits 16796 16807 +11
+ Misses 4260 4238 -22
Continue to review full report in Codecov by Sentry.
|
The (probably) only reason we had this in the past was to bundle the duplicated APIs of conversation methods in a single place. Having removed the duplication allows us to drop the module.
c82b73d
to
befb1c5
Compare
Will be done in #948 |
What's new in this PR
See title
PR Submission Checklist for internal contributors
SQPIT-764
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.