fix: MLS with unknown signature shown for other users devices RC #WPB-15268 #3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
yamilmedina,
MohamadJaara,
Garzas and
saleniuk
echoes-hq
bot
added
the
echoes: product-roadmap/bug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3860 +/- ##
==================================================
Coverage 45.69% 45.69%
==================================================
Files 473 473
Lines 16125 16125
Branches 2725 2725
==================================================
Hits 7368 7368
Misses 7990 7990
Partials 767 767
Continue to review full report in Codecov by Sentry.
|
|
Built wire-android-staging-compat-pr-3860.apk is available for download |
saleniuk
approved these changes
Feb 5, 2025
yamilmedina
approved these changes
Feb 6, 2025
MohamadJaara
deleted the
fix/mls_with_unknown_signature_shown_for_other_users_devices_rc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RC-cherry-pick of #3827
I didn't notice this fix is needed for RC too.
What's new in this PR?
Issues
When we take a look at other users devices after enabling MLS for the team, it shows “MLS with Unknown Signature” above the MLS thumbprint.
Causes (Optional)
The original issue is in CC: type of signature is unknown.
Solutions
To not make user confused: in case of unknown signature type display just "MLS" label instead of "MLS with unknown signature"
Attachments (Optional)