fix: mention draft update [WPB-12062] #3865
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
MessageCompositionHolder
where mentions were not always properly saved in the message draft.selectedMentions
was updated, leading to cases where the draft was saved without the correct mention data.Causes (Optional)
insertMentionIntoText(mention)
was called before updatingselectedMentions
, modifyingmessageTextState
immediately.onSaveDraft()
being triggered with an outdatedselectedMentions
list, causing mentions to be missing from the draft.Solutions
selectedMentions
is updated before inserting the mention into the text: