Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add conversation to folder after its creation [WPB-15892] #3867

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Feb 7, 2025

TaskWPB-15892 [Android] It should not be possible to create empty folders


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Changed flow of adding new folder to after creation move conversation to newly created folder to not have empty folders

Copy link

sonarqubecloud bot commented Feb 7, 2025

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.45%. Comparing base (038c90a) to head (ce0666f).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...conversations/folder/ConversationFoldersNavArgs.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3867      +/-   ##
===========================================
- Coverage    45.46%   45.45%   -0.01%     
===========================================
  Files          491      491              
  Lines        17008    17011       +3     
  Branches      2846     2846              
===========================================
  Hits          7733     7733              
- Misses        8488     8491       +3     
  Partials       787      787              
Files with missing lines Coverage Δ
...conversations/folder/ConversationFoldersNavArgs.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 038c90a...ce0666f. Read the comment docs.

@Garzas Garzas enabled auto-merge February 7, 2025 12:58
@Garzas Garzas added this pull request to the merge queue Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Built wire-android-staging-compat-pr-3867.apk is available for download

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Built wire-android-dev-debug-pr-3867.apk is available for download

Merged via the queue into develop with commit 94bd1dc Feb 7, 2025
12 checks passed
@Garzas Garzas deleted the fix/add-conversation-to-folder-after-creation branch February 7, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants