Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/file sharing menu no gaps #3868

Closed
wants to merge 6 commits into from

Conversation

borichellow
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@borichellow borichellow closed this Feb 7, 2025
@borichellow borichellow deleted the fix/file_sharing_menu_no_gaps branch February 7, 2025 15:43
Copy link

sonarqubecloud bot commented Feb 7, 2025

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 45.42%. Comparing base (94bd1dc) to head (7d52f27).

Files with missing lines Patch % Lines
...in/com/wire/android/notification/PendingIntents.kt 0.00% 11 Missing ⚠️
...m/wire/android/notification/NotificationActions.kt 0.00% 8 Missing ⚠️
...re/android/notification/CallNotificationManager.kt 0.00% 7 Missing ⚠️
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3868      +/-   ##
===========================================
- Coverage    45.45%   45.42%   -0.03%     
===========================================
  Files          491      491              
  Lines        17011    17022      +11     
  Branches      2846     2848       +2     
===========================================
  Hits          7733     7733              
- Misses        8491     8502      +11     
  Partials       787      787              
Files with missing lines Coverage Δ
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% <0.00%> (ø)
...re/android/notification/CallNotificationManager.kt 39.20% <0.00%> (-0.23%) ⬇️
...m/wire/android/notification/NotificationActions.kt 0.00% <0.00%> (ø)
...in/com/wire/android/notification/PendingIntents.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94bd1dc...7d52f27. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants