Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sftTokenSecret reference #725

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add sftTokenSecret reference #725

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71e1721
add sftTokenSecret reference
amitsagtani97 Aug 16, 2024
74ae4e8
update comment and add more details
amitsagtani97 Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bin/offline-secrets.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ brig:
setNexmo: |-
key: "dummy"
secret: "dummy"
# Uncomment and update value to enable sft credentials provisioning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Provisioning" is not correct, nothing is being provisioned

Maybe something like

Suggested change
# Uncomment and update value to enable sft credentials provisioning
# Uncomment to connect to SFT servers that require it```

# sftTokenSecret: dummysecret
cargohold:
secrets:
awsKeyId: "$minio_access_key"
Expand Down
4 changes: 3 additions & 1 deletion values/wire-server/prod-secrets.example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@ brig:
setNexmo: |-
key: "dummy"
secret: "dummy"
# Uncomment for federation. Set values accordingly
# Uncomment and update value to enable sft credentials provisioning
# sftTokenSecret: dummysecret
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above


# Uncomment for federation. Set values accordingly
Copy link
Contributor

@smatting smatting Aug 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set values accordingly

Sounds to me like this sentence is saying nothing.

Or is it meant to say:

Use the same credentials as in and

?

# rabbitmq:
# username: wire-server
# password: verysecurepassword
Expand Down
Loading