Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nits of #4389 #4420

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Fix nits of #4389 #4420

merged 2 commits into from
Jan 24, 2025

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Jan 24, 2025 •
edited
Loading

Fix leftover nits from #4389.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes/initiative: scale Enterprise Readiness Initiatives label Jan 24, 2025
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 24, 2025
@pcapriotti pcapriotti marked this pull request as ready for review January 24, 2025 07:40
@pcapriotti pcapriotti requested a review from battermann January 24, 2025 07:40
@battermann battermann merged commit 81ae37e into develop Jan 24, 2025
11 checks passed
@battermann battermann deleted the WPB-14307-fix-nits branch January 24, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@battermann battermann battermann approved these changes

Assignees
No one assigned
Labels
echoes/initiative: scale Enterprise Readiness Initiatives ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcapriotti @battermann @zebot