include speakingurl #377
Merged
include speakingurl #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipis
reviewed
Oct 31, 2016
test/unit_tests/util/UtilSpec.coffee
Outdated
| expect(z.util.compare_names('René', 'Rene')).toBeTruthy() | ||
|
|
||
| it 'Παναγιὡτα equals Panagiota', -> | ||
| expect(z.util.compare_names('Παναγιὡτα', 'Panagiota')).toBeTruthy() |
There was a problem hiding this comment.
Change it to: ώ instead of ὡ (in the description as well)
gregor
approved these changes
Oct 31, 2016
lipis
approved these changes
Oct 31, 2016
|
Still failing because of |
herrmannplatz
force-pushed
the
cleanup/slug
branch
from
2d72a71 to
0fd6278
Compare
|
Yes, but it should work now. Forgot to bundle speakingurl. |
bennycode
approved these changes
Nov 2, 2016
gregor
approved these changes
Nov 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove speakingurl from webapp-module-external and make it a dependency in webapp. Created a PR on the speakingurl repo with the Omega fix we used to have in our repo. I also upgraded from 4.0.0 to 10.0.0.
see pid/speakingurl#86