-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WT-14147 Fix the eviction updates trigger config log to reflect correct metric #11680
WT-14147 Fix the eviction updates trigger config log to reflect correct metric #11680
Conversation
Thanks for creating a pull request! Please answer the questions below by editing this comment. Type of change made in this PR
What makes this change safe?Answering this question helps the reviewers understand where they should focus their attention. Please consider these prompts:
References: Checklist before requesting a review
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…t_config12 pattern matching
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
When trying to check the
eviction_updates_trigger
for invalid configuration, the log incorrectly states we set the default value to half of theeviction_updates_trigger
value instead of theeviction_dirty_trigger
. Also, found a similar error in the same function inevict_conn.c
, the error message should say setting to 50% ofeviction_dirty_target
noteviction_updates_target
.Solution: fixed inconsistencies in
__evict_validate_config
config log to reflect the correct metrics and fixed pattern matching error intest_config12.py
.