Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WT-14147 Fix the eviction updates trigger config log to reflect correct metric #11680

Merged

Conversation

mariammojid
Copy link
Contributor

@mariammojid mariammojid commented Mar 5, 2025

When trying to check the eviction_updates_trigger for invalid configuration, the log incorrectly states we set the default value to half of the eviction_updates_trigger value instead of the eviction_dirty_trigger. Also, found a similar error in the same function inevict_conn.c, the error message should say setting to 50% of eviction_dirty_target not eviction_updates_target.

Solution: fixed inconsistencies in __evict_validate_config config log to reflect the correct metrics and fixed pattern matching error in test_config12.py.

@mariammojid mariammojid requested a review from Sean04 March 5, 2025 04:27
Copy link

github-actions bot commented Mar 5, 2025

Thanks for creating a pull request! Please answer the questions below by editing this comment.

Type of change made in this PR

  • Functional change
  • Test-only change
  • Refactor-only change
  • Other non-functional change

What makes this change safe?

Answering this question helps the reviewers understand where they should focus their attention. Please consider these prompts:

  • How risky is this change? Why?
    → Low risk, very small change to an error message. This will highly unlikely affect other processes.
  • What tests are you adding, changing or relying on? Why?
    → There is no need for tests as it is a very straightforward fix in an error message.
  • What, if anything, are you concerned about that you'd like the reviewer to focus on?
    → No concerns.

References:

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation, or no documentation change is needed.
  • I have tests that show my change is correct, or have described above why functional test changes are not required.

Copy link
Contributor

@Sean04 Sean04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mariammojid mariammojid requested review from bzm-jas and Sean04 March 6, 2025 00:05
Copy link
Contributor

@Sean04 Sean04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@bzm-jas bzm-jas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariammojid mariammojid added this pull request to the merge queue Mar 6, 2025
Merged via the queue into develop with commit 16f06d3 Mar 6, 2025
11 checks passed
@mariammojid mariammojid deleted the WT-14147-fix-eviction-updates-trigger-config-log branch March 6, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants