Skip to content

Commit

Permalink
Merge pull request #85 from wiremock/contributing-docs
Browse files Browse the repository at this point in the history
Move the contributing guide to the documentation and publish it on the site
  • Loading branch information
oleg-nenashev authored Aug 8, 2023
2 parents 4d25835 + 067f9cc commit d67c969
Show file tree
Hide file tree
Showing 6 changed files with 73 additions and 36 deletions.
31 changes: 0 additions & 31 deletions CONTRIBUTING.md

This file was deleted.

8 changes: 6 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ WireMock can run in unit tests, as a standalone process or a container. Key feat

- [Testcontainers Python](https://github.com/testcontainers/testcontainers-python) module to easily start WireMock server for your tests
- REST API Client for a standalone WireMock Java server
- Support for most of ajor [WireMock features ](https://wiremock.org/docs) (more on their way soon)
- Support for most of major [WireMock features ](https://wiremock.org/docs) (more on their way soon)

## References

Expand All @@ -33,9 +33,13 @@ WireMock can run in unit tests, as a standalone process or a container. Key feat

## Examples

There are several [example projects](./examples/) included to demonstrate the different ways that wiremock can be used to mock
There are several [example projects](./examples/) included to demonstrate the different ways that WireMock can be used to mock
services in your tests and systems. The example test modules demonstrate different strategies for testing against
the same "product service" and act as a good demonstration of real world applications to help you get started.

- [Testcontainers Python](examples/intro/tests/test_testcontainers.py)
- [Standalone Java Server Version](examples/intro/tests/test_java_server.py)

## Contributing

See the [Contributor Guide](./docs/CONTRIBUTING.md)
63 changes: 63 additions & 0 deletions docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
# Contributing to Python WireMock

[![a](https://img.shields.io/badge/slack-%23wiremock%2Fpython-brightgreen?style=flat&logo=slack)](https://slack.wiremock.org/)

WireMock exists and continues to thrive due to the efforts of over 150 contributors, and we continue to welcome contributions to its evolution. Regardless of your expertise and time you could dedicate, there’re opportunities to participate and help the project!

This page covers contributing to _Python WireMock_.
For generic guidelines and links to other technology stacks,
see [this page](https://wiremock.org/docs/participate/).

## Get Started

1. Join us ion the `#wiremock-python` channel on the [WireMock Slack](https://slack.wiremock.org/)
2. Check out the GitHub issues!

## Pull Requests

All patches to the repository are done via pull requests.
No special prerequisites exist, you can just submit the patches!
General expectations:

- All Tests and static checkers must pass
- Code coverage shouldn't decrease
- All Pull Requests should be rebased against master **before** submitting the PR.
- The Pull Request titles represent the change well for users or developers

## Development

We use [Poetry](https://python-poetry.org/) for packaging and dependency management.

After forking and cloning the repository,
run the following command to setup the project:

`poetry install`

Then use your favorite IDE for development and testing.

## Contributing examples

Please submit new examples as a pull requests to the
[examples directory]([./examples/](https://github.com/wiremock/python-wiremock/tree/master/examples)).
You can also also add links to external examples and tutorials to the `README.md`
file in the directory.

When adding new examples,
make sure to update the [documentation site page](./examples.md) too.

## Working on Documentation

The documentation is powered by [MkDocs](https://www.mkdocs.org/) and [ReadTheDocs](https://readthedocs.org/).
All the necessary dependencies are included into the Poetry definition.
To build the docs locally:

```bash
poetry run mkdocs build --site-dir=html
```

MkDocs also comes with a built-in dev-server that lets you preview your documentation as you work on it by running the `mkdocs serve` command.
By default, it will deploy the live documentation site to `http://localhost:8000`.

## See also

- [Contributing to WireMock](https://wiremock.org/docs/participate/)
4 changes: 2 additions & 2 deletions docs/examples.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
## External examples

No external examples are referenced at the moment.
Please be welcome to [contribute]([./../CONTRIBUTING.md](https://github.com/wiremock/python-wiremock/blob/master/CONTRIBUTING.md))!
Please be welcome to [contribute](./CONTRIBUTING.md)!

## Contributing examples

More examples are always welcome!
See the [Contributor Guide]([./../CONTRIBUTING.md](https://github.com/wiremock/python-wiremock/blob/master/CONTRIBUTING.md)).
See the [Contributor Guide](./CONTRIBUTING.md).
2 changes: 1 addition & 1 deletion examples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
## External examples

No external examples are referenced at the moment.
Please be welcome to [contribute](./../CONTRIBUTING.md)!
Please be welcome to [contribute](../docs/CONTRIBUTING.md)!

## Contributing

Expand Down
1 change: 1 addition & 0 deletions mkdocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ nav:
- Installation: install.md
- Testcontainers: testcontainers.md
- Standalone: api-client.md
- Contributing: CONTRIBUTING.md
- Resources:
- Examples: examples.md
- Changelog: changelog.md

0 comments on commit d67c969

Please sign in to comment.