Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Requests.reset_request_journal() for Wiremock V3 #108

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Fix Requests.reset_request_journal() for Wiremock V3 #108

merged 2 commits into from
Dec 17, 2024
+2 −2

Conversation

alexjircan
Copy link
Contributor

@alexjircan alexjircan commented Dec 16, 2024 •
edited
Loading

Closes #95

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@leeturner
Copy link
Contributor

This looks great. I am just seeing if I can sort out the integration tests here - #111

@leeturner
Copy link
Contributor

Do you want to pull in the main branch into this PR and we can get a green run of the integration tests and then we can get this merged 👍

@alexjircan
Copy link
Contributor Author

Shouldn't we enable auto squash merge for this repo?

@leeturner leeturner merged commit 6d014e0 into wiremock:master Dec 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requests.reset_request_journal() doesn't work with Wiremock V3
2 participants
@alexjircan @leeturner