Update WireMock to version 3.6.0 to allow use of the start() method #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WireMock 3.6.0 provided the start() and stop() extension lifecycle methods which can be used to initialise extensions when WireMock starts and allow them to perform and cleanup when WireMock shuts down. This plugin used a hack to initialise the jwt so this change removes the hack in favour of the new start() method
leeturner
commented
May 26, 2024
|
|
||
| private void initialise() { | ||
| if (!initialised) { |
There was a problem hiding this comment.
I am thinking we probably don't need all of this now, given start only happens once during wiremock initialisation
As the new start() method is only called once during wiremock initialisation we no longer need the initialised flag or the synchronised block.
# Conflicts: # build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WireMock 3.6.0 provided the start() and stop() extension lifecycle methods which can be used to initialise extensions when WireMock starts and allow them to perform and cleanup when WireMock shuts down.
This plugin used a hack to initialise the jwt so this change removes the hack in favour of the new start() method