Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new fake data helper to response-templating.md #211

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Add new fake data helper to response-templating.md #211

merged 6 commits into from
Dec 8, 2023

Conversation

Shreya-7
Copy link
Contributor

References

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • If the change against WireMock 2 functionality (incompatible with WireMock 3),
    it is submitted against the 2.x branch
  • The repository's code style is followed (see the contributing guide)

Details: Contributor Guide

@Shreya-7 Shreya-7 changed the title Add new fake data helper to response-templating.md Draft: Add new fake data helper to response-templating.md Oct 14, 2023
oleg-nenashev
oleg-nenashev suggested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Since the feature comers from an extension, it would be nice to document it explicitly. For now you can reference the GitHub repository while we're working on better Extension listing

_docs/response-templating.md Outdated
@@ -631,6 +631,19 @@ Likewise decimals can be produced with or without bounds:

{% endraw %}

## Fake data helpers

These helpers produce random fake data of the desired types available in the [Data Faker library]([url](https://github.com/datafaker-net/datafaker)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to document how to get this extension, because it is not an out of the box one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I had written this when I had this implemented this feature as a core helper instead of an extension. Have marked this PR as draft and will update as per comments, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

@oleg-nenashev oleg-nenashev added hacktoberfest-accepted documentation Improvements or additions to documentation labels Oct 16, 2023
@Shreya-7 Shreya-7 marked this pull request as draft October 16, 2023 05:49
@Shreya-7 Shreya-7 changed the title Draft: Add new fake data helper to response-templating.md Add new fake data helper to response-templating.md Oct 16, 2023
@Shreya-7 Shreya-7 marked this pull request as ready for review October 16, 2023 16:53
oleg-nenashev
oleg-nenashev approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now we need a release

@Shreya-7
Copy link
Contributor Author

OK, now we need a release

What's the process for that?

@oleg-nenashev
Copy link
Member

@Shreya-7 see my ping on Slack about trying out the release flow (#wiremock-java channel)
https://github.com/wiremock/community/blob/main/infra/maven-central.md for the guide though we still need to verify it.
wiremock/wiremock-state-extension#72 for the PoC for Gradle (testing in progress)

@oleg-nenashev
Copy link
Member

Also, did I resolve the merge conflict correctly?

@Shreya-7
Copy link
Contributor Author

Shreya-7 commented Nov 5, 2023

Also, did I resolve the merge conflict correctly?

I see some new changes got added from line 941 - was that intentional?

@Shreya-7
Copy link
Contributor Author

Shreya-7 commented Nov 5, 2023

@Shreya-7 see my ping on Slack about trying out the release flow (#wiremock-java channel) https://github.com/wiremock/community/blob/main/infra/maven-central.md for the guide though we still need to verify it. wiremock/wiremock-state-extension#72 for the PoC for Gradle (testing in progress)

sorry I've been away, busy with work stuff. Do you need me to setup the entire release workflow for this repo?

oleg-nenashev
oleg-nenashev approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's integrate it given the extension is ready for local testing. I will do the release next week

@oleg-nenashev oleg-nenashev merged commit 2087eba into wiremock:main Dec 8, 2023
1 check passed
@oleg-nenashev oleg-nenashev mentioned this pull request Dec 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shreya-7 @oleg-nenashev