Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NPM to distributions list #222

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Add NPM to distributions list #222

merged 2 commits into from
Oct 30, 2023

Conversation

maelstrom0x8
Copy link
Contributor

This PR adds the NPM distribution of WireMock to the official documentation, specifically in the list of available distributions on the WireMock website which links to the Node.js solutions page.

Closes: wiremock/wiremock-npm#5

References

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • If the change against WireMock 2 functionality (incompatible with WireMock 3),
    it is submitted against the 2.x branch
  • The repository's code style is followed (see the contributing guide)

Details: Contributor Guide

@oleg-nenashev oleg-nenashev added documentation Improvements or additions to documentation hacktoberfest-accepted labels Oct 28, 2023
oleg-nenashev
oleg-nenashev suggested changes Oct 28, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I suggest using another page so that refers a distribution itself

_docs/index.html Outdated Show resolved Hide resolved
@oleg-nenashev
Update _docs/index.html
3d03259 
Co-authored-by: Oleg Nenashev <[email protected]>
oleg-nenashev
oleg-nenashev approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oleg-nenashev oleg-nenashev merged commit f73546d into wiremock:main Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the NPM distribution to the WireMock site
3 participants
@maelstrom0x8 @oleg-nenashev @megalith7CC