Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update styles to be more inline with wiremock branding #225

Merged
merged 19 commits into from
Nov 17, 2023
Merged

Update styles to be more inline with wiremock branding #225

merged 19 commits into from
Nov 17, 2023

Conversation

limptwiglet
Copy link
Member

@limptwiglet limptwiglet commented Nov 13, 2023 •
edited
Loading

Update site styles to be more inline with wiremock branding.

image
image
image

Mobile:
image
image
image
image
image
image

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • If the change against WireMock 2 functionality (incompatible with WireMock 3),
    it is submitted against the 2.x branch
  • The repository's code style is followed (see the contributing guide)

Details: Contributor Guide

@limptwiglet limptwiglet changed the title Update styles Update styles to be more inline with wiremock branding Nov 13, 2023
oleg-nenashev
oleg-nenashev reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some screenshots would be nice, hard to review instead

@limptwiglet
Copy link
Member Author

Some screenshots would be nice, hard to review instead

Updated with screenshots

oleg-nenashev
oleg-nenashev reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current "Downloads" layout is better than the one suggested in the PR. No objections for other entries

@limptwiglet
Copy link
Member Author

I think the current "Downloads" layout is better than the one suggested in the PR. No objections for other entries

Agreed, latest commit reverts and improves the previous downloads section

oleg-nenashev
oleg-nenashev approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@limptwiglet limptwiglet merged commit 30910b2 into main Nov 17, 2023
1 check passed
@limptwiglet limptwiglet deleted the update-styles branch November 17, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@limptwiglet @oleg-nenashev