Merge pull request #47 from wirepair/fix_blocked_channel

always send ready channel when exiting probeDebugPort

CHANGELOG.md

@@ -1,5 +1,5 @@
 # Changelog (2021)
-
+- 2.1.3 (June 4th): Fix a potential blocked channel if chrome fails to start and debug port probe fails
 - 2.1.2 (May 23rd): Update to chrome version 90.0.4430.212
   - Implementation of an observer package to allow inspection of messages between gcd/browser by @camswords
 

v2/gcd.go

@@ -44,7 +44,7 @@ import (
 
 var json = jsoniter.ConfigCompatibleWithStandardLibrary
 
-var GCDVERSION = "v2.1.2"
+var GCDVERSION = "v2.1.3"
 
 var (
 	ErrNoTabAvailable = errors.New("no available tab found")
@@ -443,6 +443,7 @@ func (c *Gcd) probeDebugPort() error {
 	defer func() {
 		ticker.Stop()
 		timeoutTicker.Stop()
+		c.readyCh <- struct{}{}
 	}()
 
 	for {
@@ -453,7 +454,6 @@ func (c *Gcd) probeDebugPort() error {
 				continue
 			}
 			defer resp.Body.Close()
-			c.readyCh <- struct{}{}
 			return nil
 		case <-timeoutTicker.C:
 			return fmt.Errorf("Unable to contact debugger at %s after %d seconds, gave up", c.apiEndpoint, c.timeout)