Skip to content

Commit

Permalink
update changelog, fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
= committed Oct 16, 2024
1 parent c1da3dc commit c256d5b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# Changelog (2024)
- 2.3.5 (Oct 16)
- Fix apigen to use ToT from github for downloading json files. Update to latest protocol
- 2.3.4 (Mar 18)
- Fix return types for calls that return two-dimensional arrays
- 2.3.3 (Jan 31)
Expand Down
7 changes: 3 additions & 4 deletions v2/gcd_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,6 @@ func testCleanUp() {
}

func TestDeleteProfileOnExit(t *testing.T) {
if runtime.GOOS == "windows" {
//t.Skip("windows will hold on to the process handle too long")
}

debugger := NewChromeDebugger(WithDeleteProfileOnExit(),
WithFlags([]string{"--headless"}),
)
Expand All @@ -75,6 +71,9 @@ func TestDeleteProfileOnExit(t *testing.T) {
if err != nil {
t.Fatalf("error starting chrome: %s\n", err)
}

debugger.NewTab()

debugger.ExitProcess()
time.Sleep(3 * time.Second)
if stat, err := os.Stat(profileDir); err == nil {
Expand Down

0 comments on commit c256d5b

Please sign in to comment.