-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update readme #133
Conversation
8d4bee3
to
e773bf4
Compare
A better description for the |
git clone <repo url> | ||
cd <working copy> | ||
git checkout dev | ||
pip3 install -e . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure this workflow makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you also mention something like the alternative variant you gave to me in #43 (comment)?
git clone https://github.com/formatc1702/WireViz.git
cd WireViz/
python -m venv wv-env
source wv-env/bin/activate
pip3 install -e .
cd src/wireviz
python build_examples.py
Note that git checkout dev
is missing above, and I have not tried any of these installations from scratch recently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a link to CONTRIBUTING.md
near the end of the section about Installing the development version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, didn't see these comments earlier.
- I'm not sure whether we should give advice on virtual environments directly, or reference a site that explains the concept more generally.
- Sure, I can include a link to
CONTRIBUTING.md
See PR #118 description for a short summary in the Usage section, and a couple of use cases in the last section, to get some ideas. |
It might make sense to create a |
I'm merging this into |
I've restructured the main README file, added and moved around some of the information. I welcome any new input to make the readme more user-friendly.